Add a more aggressive fast-path for Invoke(object[])#372
Open
WAcry wants to merge 8 commits intodynamicexpresso:masterfrom
Open
Add a more aggressive fast-path for Invoke(object[])#372WAcry wants to merge 8 commits intodynamicexpresso:masterfrom
Invoke(object[])#372WAcry wants to merge 8 commits intodynamicexpresso:masterfrom
Conversation
Enhance Eval and Lambda classes: introduce preferInterpretation flag for optimized expression evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
#372 currently contains all commits from #371 plus one extra commit.
What & why
Invoke(object[])is a common hot path. Even after #371, the fallback path still pays for:usedArgs(when declared != used), and/orDynamicInvokeoverhead.This PR introduces an additional fast-path that, when applicable, bypasses both costs.
Changes
Invoke(object[])fast-path:Lambda’s internalInvocationContext, compile once aFunc<object[], object>“fast invoker”.Invoke(object[])meets the type assignability / nullable-compatibility constraints, invoke via the fast invoker:DynamicInvokeusedArgsusedArgs+DynamicInvokeBenchmark results
Environment:
v0.14.010.0.26200.7705)8.0.23(x64 RyuJIT)10.0.102Raw numbers
Derived comparisons
Notes:
Invoke(object[]):(in this benchmark scenario)
Invoke(IEnumerable<Parameter>)/Eval(...)are effectively unchanged from #371 — this fast-path is intentionally targeted at declared-orderobject[].