Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 86.80% 88.79% +1.98%
==========================================
Files 20 27 +7
Lines 1993 2819 +826
==========================================
+ Hits 1730 2503 +773
- Misses 263 316 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ges and add tests for java list/resolve and SDKMAN resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors to the Java environment management package, focusing on supporting multiple Java distributions and download backends (including SDKMAN), improving documentation, optimizing JSON parsing, and expanding the API for listing and clearing Java installations. The changes are grouped below by theme.
Backend and Distribution Support
nativeorsdkman) and distribution (Corretto,Temurin,Zulu) in key functions likejava_download,java_ensure, andjava_install, with automatic detection of SDKMAN identifiers and related metadata handling. [1] [2] [3] [4] [5] [6] [7] [8] [9]version,distribution, andbackendarguments, including new placeholder documentation functions for global parameters. [1] [2] [3]API Expansion
java_clear_distrib,java_clear_installed,java_clear_project,java_list_available,java_list_distrib,java_list_installed, andjava_list_project. [1] [2]Performance and Reliability
jsonlitetoRcppSimdJsonfor faster and more robust configuration file and URL parsing, and added helper functions for reading JSON and lines from URLs. [1] [2]Refactoring and Robustness
Documentation and Minor Enhancements
These changes collectively improve the flexibility, performance, and usability of the package for managing Java environments across different distributions and installation contexts.