Conversation
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension.
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension. - Update scripts to address PR review feedback (robust dependency handling, verification).
- Use `mcr.microsoft.com/devcontainers/r:latest` as base image. - Exclude `rJava` from dependency installation to keep container Java-free. - Install Posit Air CLI and VS Code extension. - Install Quarto extension. - Update scripts to address PR review feedback (pinned version, security, robustness).
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses CRAN submission requirements by fixing documentation formatting, improving test reliability, adding development container support, and enhancing validation error messages.
Changes:
- Changed documentation formatting from bold (
\strong) to italic (\emph) for package name "rJava" throughout documentation files - Improved test reliability by updating mock filename to be parseable and adding Windows skip condition
- Added devcontainer configuration for development environment setup
- Added duplicate validation logic in
java_installfunction (already present injava_unpack)
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/meta-data-update-and-submission.R | Added commented-out devtools check commands for CRAN submission workflow |
| tests/testthat/test-java_install-mocked.R | Fixed test by using parseable filename and adding Windows skip condition |
| man/use_java.Rd | Changed rJava package name from bold to italic formatting |
| man/rjava_path_locking_note.Rd | Changed rJava package name from bold to italic formatting |
| man/java_env_set.Rd | Changed rJava package name from bold to italic formatting |
| man/java_ensure.Rd | Changed rJava package name from bold to italic formatting |
| R/java_install.R | Added validation error checks for version, arch, and platform detection |
| R/internal_utilities.R | Added @nord tag to internal function documentation |
| R/global_params.R | Changed rJava package name from bold to italic formatting in source |
| .devcontainer/setup.sh | Added bash script for devcontainer setup with Posit Air CLI installation |
| .devcontainer/setup.R | Added R script to install dependencies excluding rJava |
| .devcontainer/devcontainer.json | Added VS Code devcontainer configuration |
| .Rbuildignore | Added devcontainer-related directories to build ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 27 27
Lines 2819 2819
=======================================
Hits 2503 2503
Misses 316 316 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.