Adding workflow durability by allowing persistence between each stage#59
Open
cortexteam wants to merge 1 commit intoe2ebridge:masterfrom
Open
Adding workflow durability by allowing persistence between each stage#59cortexteam wants to merge 1 commit intoe2ebridge:masterfrom
cortexteam wants to merge 1 commit intoe2ebridge:masterfrom
Conversation
Member
|
@cyrilschmitt what do you think about this enhancement? |
cyrilschmitt
requested changes
Nov 30, 2018
Member
cyrilschmitt
left a comment
There was a problem hiding this comment.
Hello cortexteam,
Thank you for contributing, the ideas are valid but I have some remarks before merging this.
I would like it in multiple commits because I think there are different unrelated changes:
- getNumberOfProcesses
- delete and _autoCleanFinishedProcess (these are related so OK for both in one commit)
- persist and resumeProcess (also related so one commit)
I think resumeProcess should also take processName parameter because in case the manager have multiple processDefinitions then this can be wrong:
Object.keys(self._processDefinitions)[0]
It would alsways use the first definition so replace by processName parameter.
Regards,
Cyril
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an optional callback which can be used to persist the message state at each workflow stage to allow long-running workflows to become durable and resumable.