redirect uri should be RuName, not a url.#4
Open
soenkegissel wants to merge 4 commits intoeBay:masterfrom
Open
redirect uri should be RuName, not a url.#4soenkegissel wants to merge 4 commits intoeBay:masterfrom
soenkegissel wants to merge 4 commits intoeBay:masterfrom
Conversation
Author
|
Added the fully qualified package name to AndroidManifest to be usable when importing as a library. Before it was ClassNotFound exception as it was looked for in com.myapp.oauth2.ui.OAuthRedirectActivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In AuthorizationLink.kt some unfulfillable checks leave the user no choice but to enter invalid information.

For redirect uri the RuName should be enterned (eg. Davy_Developer-DavyDeve-DavysT-euiukxwt) not https://my-accept-url.
You can get more information here (https://developer.ebay.com/api-docs/static/oauth-consent-request.html):
You checks for uri begin with https:// is unfulfillable. As well as the check if redirect uri equals the informations entered in AndroidManifest.xml.
Later on when I exchange the authorization code for a User access token I enter redirect uri as RuName as well (https://developer.ebay.com/api-docs/static/oauth-auth-code-grant-request.html):
