Breaking: implement asyncio support.#13
Open
asaf-kali wants to merge 1 commit intoeSAMTrade:masterfrom
Open
Conversation
tl24
reviewed
Jul 7, 2025
| while _tries: | ||
| try: | ||
| return f() | ||
| return await f() |
There was a problem hiding this comment.
It's possible to conditionally await by calling inspect.isawaitable. Not sure if you can keep the signature without the await, or do an equivalent of an await call using some library function:
is_async = False
value = f()
if inspect.isawaitable(value):
is_async = True
value = await value
return value
is_async could potentially be used in the except block to determine which sleep method to use
There was a problem hiding this comment.
I couldn't find a way to keep the signature intact. And also went with inspect module to find out whether it's dealing with an async function: my implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for this issue.
Usage: