Fix client name and tags handling #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I knew a long time ago, but had never really hard evidence for it, started to wreck havock in certain circumstances, because the UpdateSettings method can be called in parallel. As such, you need to ensure that changes to the underlying cache values as well as reading from them, is properly handled, otherwise you run into "fun" race conditions and crashes.
This fixes #48
Additionally, I realized that the client name and tag filtering was done in a wrong way, thus not actually getting applied.
Included fixes / changes:
{projectName}or{ProjectName}or{projectname})