Conversation
qrizzl
left a comment
There was a problem hiding this comment.
-
adding effect cards is not part of making powers rollable from the sheet ;P
-
I personally don't think there should be editing of embedded documents in an embedded document in a sheet. Show the effects, but if you wanna change stuff, you have to do it consciously from the document the effect belongs to. I don't really see a use case for having the effects in the list at all, maybe you can give me some examples? Currently makes it only look crowded for me.
Also, if it stays, this needs to be styled differently, to be at least aligned.

| aria-label="Roll {{name}}"> | ||
| </button> | ||
| {{else}} | ||
| {{#if (and (ne this.system.strain 0) this.system.rollType)}} |
There was a problem hiding this comment.
Why do I need a rollType if it doesn't have a step and therefore not a roll?
There was a problem hiding this comment.
for strain similar to the talents like sprint, they show up as blood drops to use them and take the strain for activation
There was a problem hiding this comment.
Yes, that I understand. But why the condition to have a rolltype? Shouldn't it explicitly not have rolltype? To make it clear, that this doesn't roll, but only strains?
| <div class="card__description card__description--toggle display__inline-block"> | ||
| <span class="card__description--content"> | ||
| {{{system.description.value}}} | ||
| <span class="card__description--content">} |
There was a problem hiding this comment.
there's a stray curly brace at the end of the line. needs to be deleted, otherwise it will be rendered like that
There was a problem hiding this comment.
oh good catch
|
the idea is simple. (and yes the styling was not perfect). almost all creatures have powers which are not really rolled but provide effects. Some of them are easy, because they are always "active" but others like frenzy, auras, manifestations, etc. (there are a lot) need to be activated only when needed. you mentioned that those effects should not be handled on the actor sheet. The alternative would be 3 clicks more for every time plus an extra item dialog to close again, that is a lot for a gm. but I can see the thrash bin to be out of place for these effects. |
this enables powers to be rolled from the actual tab
in addition, i enabled the EAEs extended card views to be activatable