Skip to content

Fix powers to be rollable#3434

Draft
patrickmohrmann wants to merge 2 commits intomainfrom
fix-powers-to-be-rollable
Draft

Fix powers to be rollable#3434
patrickmohrmann wants to merge 2 commits intomainfrom
fix-powers-to-be-rollable

Conversation

@patrickmohrmann
Copy link
Collaborator

this enables powers to be rolled from the actual tab

in addition, i enabled the EAEs extended card views to be activatable

Copy link
Collaborator

@qrizzl qrizzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. adding effect cards is not part of making powers rollable from the sheet ;P

  2. I personally don't think there should be editing of embedded documents in an embedded document in a sheet. Show the effects, but if you wanna change stuff, you have to do it consciously from the document the effect belongs to. I don't really see a use case for having the effects in the list at all, maybe you can give me some examples? Currently makes it only look crowded for me.

Also, if it stays, this needs to be styled differently, to be at least aligned.
Image

aria-label="Roll {{name}}">
</button>
{{else}}
{{#if (and (ne this.system.strain 0) this.system.rollType)}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I need a rollType if it doesn't have a step and therefore not a roll?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for strain similar to the talents like sprint, they show up as blood drops to use them and take the strain for activation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that I understand. But why the condition to have a rolltype? Shouldn't it explicitly not have rolltype? To make it clear, that this doesn't roll, but only strains?

<div class="card__description card__description--toggle display__inline-block">
<span class="card__description--content">
{{{system.description.value}}}
<span class="card__description--content">}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a stray curly brace at the end of the line. needs to be deleted, otherwise it will be rendered like that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch

@qrizzl qrizzl assigned patrickmohrmann and alegionofone and unassigned qrizzl Jan 3, 2026
@patrickmohrmann
Copy link
Collaborator Author

the idea is simple. (and yes the styling was not perfect).

almost all creatures have powers which are not really rolled but provide effects. Some of them are easy, because they are always "active" but others like frenzy, auras, manifestations, etc. (there are a lot) need to be activated only when needed.

you mentioned that those effects should not be handled on the actor sheet. The alternative would be 3 clicks more for every time plus an extra item dialog to close again, that is a lot for a gm.

but I can see the thrash bin to be out of place for these effects.

@patrickmohrmann patrickmohrmann marked this pull request as draft January 31, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments