Skip to content

🐛 3056 bug substitute attacks use highest rank for all#3461

Merged
qrizzl merged 3 commits intomainfrom
3056-bug-substitute-attacks-use-highest-rank-for-all
Feb 18, 2026
Merged

🐛 3056 bug substitute attacks use highest rank for all#3461
qrizzl merged 3 commits intomainfrom
3056-bug-substitute-attacks-use-highest-rank-for-all

Conversation

@patrickmohrmann
Copy link
Collaborator

@patrickmohrmann patrickmohrmann commented Jan 24, 2026

Fixes #3056
Fixes #3182

Substitute attacks are now working and not taken always the highest attack rank

in addition, moved switch weapon, draw weapon and check equipped weapon to actor.mjs from ability.mjs

qrizzl
qrizzl previously approved these changes Feb 2, 2026
@qrizzl qrizzl dismissed their stale review February 2, 2026 18:46

CLicked the wrong button

@qrizzl qrizzl changed the title 3056 bug substitute attacks use highest rank for all 🐛 3056 bug substitute attacks use highest rank for all Feb 6, 2026
@qrizzl qrizzl self-requested a review February 7, 2026 16:30
@qrizzl qrizzl force-pushed the 3056-bug-substitute-attacks-use-highest-rank-for-all branch from e5da4f5 to 1d4616b Compare February 15, 2026 18:07
@qrizzl qrizzl removed their assignment Feb 15, 2026
Copy link
Collaborator

@qrizzl qrizzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated a few things, please re-check if it still works.
This now also includes #3182 since it is part of the refactored method.

@qrizzl qrizzl added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 46e4a6a Feb 18, 2026
8 checks passed
@qrizzl qrizzl deleted the 3056-bug-substitute-attacks-use-highest-rank-for-all branch February 18, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ensure off hand weapons do not trigger weapon choice prompt [BUG]-Substitute attacks use highest rank for all

2 participants

Comments