Open
Conversation
Member
Author
Default paletteMix paletteLight paletteAll colors |
Member
Author
|
@easystats/maintainers not sure if it's worth adding to the package? |
Member
|
On light background, I find them very hard to distinguish (especially the default one) |
Contributor
|
They would look nice on an off-white or beige background |
Member
|
Why not. But I agree with Etienne the default palette is a bit hard on the eyes I feel |
bwiernik
reviewed
Oct 15, 2024
| grey = "#595645", | ||
| beige = "#9A8351", | ||
| # fontana palette | ||
| scarlett = "#7D2D36", |
Contributor
There was a problem hiding this comment.
Suggested change
| scarlett = "#7D2D36", | |
| scarlet = "#7D2D36", |
| `light amber` = "#D49C02", | ||
| `light grey`= "#898765", | ||
| `light beige` = "#C4A362", | ||
| `light scarlett` = "#A73C46", |
Contributor
There was a problem hiding this comment.
Suggested change
| `light scarlett` = "#A73C46", | |
| `light scarlet` = "#A73C46", |
| full = tate_colors(), | ||
| modern = tate_colors("yellow", "rose", "red", "brown", "grey", "dark green"), | ||
| mix = tate_colors ( | ||
| "light rose", "light scarlett", "leight beige", "light grey", |
Contributor
There was a problem hiding this comment.
Suggested change
| "light rose", "light scarlett", "leight beige", "light grey", | |
| "light rose", "light scarlet", "leight beige", "light grey", |
| "blue", "orange", "teal", "mint" | ||
| ), | ||
| history = tate_colors("dark green", "grey", "brown", "beige", "amber"), | ||
| fontana = tate_colors("scarlett", "red", "rose", "yellow"), |
Contributor
There was a problem hiding this comment.
Suggested change
| fontana = tate_colors("scarlett", "red", "rose", "yellow"), | |
| fontana = tate_colors("scarlet", "red", "rose", "yellow"), |
Contributor
There was a problem hiding this comment.
scarlet and red look super similar to me. I would consider removing one of them
| "light rose", "light scarlett", "leight beige", "light grey", | ||
| "blue", "orange", "teal", "mint" | ||
| ), | ||
| history = tate_colors("dark green", "grey", "brown", "beige", "amber"), |
Contributor
There was a problem hiding this comment.
maybe make this one default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.