This repository was archived by the owner on Jan 13, 2026. It is now read-only.
A better way to reference the global window.ga#97
Open
wbazant wants to merge 1 commit intoebiwd:v1.2from
wbazant:v1.2
Open
A better way to reference the global window.ga#97wbazant wants to merge 1 commit intoebiwd:v1.2from wbazant:v1.2
wbazant wants to merge 1 commit intoebiwd:v1.2from
wbazant:v1.2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR was my mistake and I clearly didn't test enough, sorry!
Instead of "catch when ga is undefined" reference the global object from window
You can't use an undefined global - that's the scenario for Uncaught ReferenceError - unless by seeing if it's present in window (says the Internet)
mitigates #96
This reverts commit 3286d81