-
Notifications
You must be signed in to change notification settings - Fork 119
authenticated remote signer requests #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for taquito-test-dapp canceled.
|
|
Nice work @e-asphyx ! Can you revert/remove the updates to package-lock files, please? How trivial/cumbersome would it be to get unit tests added for this? Vs integration tests. I guess integration tests would either require mocking a signer server in typescript, or relying on a signatory instance? |
|
A new deploy preview is available on Netlify at https://c9702f9d--tezostaquito.netlify.app |
roxaneletourneau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-asphyx Can you add tests to the PR?
|
Hello @e-asphyx Can you add tests to the PR? Let me know, thanks! |
5521bcc to
2590c84
Compare
|
A new deploy preview for taquito.io is available on Cloudflare Pages at https://23be0b03.taquito-584.pages.dev |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
…nticated requests
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.