Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
|
Also blocked by doctrine/migrations#1406 |
| $this->shouldNotReplaceChildren($result); | ||
| } | ||
|
|
||
| public function testNormalizeDoesntReplaceWhenTargetEntityIsMissing() { |
There was a problem hiding this comment.
why did you delete this test?
|
Blocked by doctrine/migrations#1406 |
|
Implemented workaround described here: |
BacLuc
left a comment
BacLuc
left a comment
There was a problem hiding this comment.
LGTM, except for an answer for the deleted test.
Tested:
on top of this branch: detects synced schema, everything is fine.
When adding a column to an entity -> missing migration is detected and generated, exit code is not zero for the validation.
When adding a column too much in a migration -> difference is detected, migration to remove column is generated, not zero exit code for validation.
When switching from a database state on devel to this commit:
already at newest migration, nothing happens.
| working-directory: api | ||
|
|
||
| - run: php bin/console doctrine:schema:validate -v -e test | ||
| - run: php bin/console doctrine:schema:validate --skip-sync -e test && php bin/console doctrine:migrations:up-to-date -e test && ! php bin/console doctrine:migrations:diff -e test --namespace DoctrineMigrations |
There was a problem hiding this comment.
| - run: php bin/console doctrine:schema:validate --skip-sync -e test && php bin/console doctrine:migrations:up-to-date -e test && ! php bin/console doctrine:migrations:diff -e test --namespace DoctrineMigrations | |
| - run: php bin/console doctrine:schema:validate --skip-sync -e test && php bin/console doctrine:migrations:up-to-date -e test && ! php bin/console doctrine:migrations:diff -e test --namespace DoctrineMigrations --silent --allow-empty-migrations |
has the non zero exit code but does not show the error banner
testNormalizeDoesntReplaceWhenTargetEntityIsMissing
pmattmann
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
…trine-orm-3 # Conflicts: # api/composer.json # api/composer.lock
BacLuc
force-pushed
the
chore/doctrine-orm-3
branch
from
82435fc to
c10d591
Compare
3 participants
In the meantime, orm-3 compatibility was merged into main branch of https://github.com/doctrine-extensions/DoctrineExtensions
This PR is opened as draft to test orm-3 and to be ready, once the next version of DoctrineExtension is released