CampCollaboration do not embed Camp#7135
Merged
pmattmann merged 2 commits intoecamp:develfrom Apr 11, 2025
Merged
Conversation
Contributor
|
Cool. |
Member
Author
For CampCollaboration-Item it says: Of course we will change more... one PR after the other 😉 |
BacLuc
approved these changes
Mar 29, 2025
| 'groups' => ['read', 'CampCollaboration:User'], | ||
| 'swagger_definition_name' => 'read', | ||
| ]; | ||
| public const COLLECTION_NORMALIZATION_CONTEXT = [ |
Contributor
There was a problem hiding this comment.
do we need the embedding of the camp in the collection request?
simfeld
approved these changes
Apr 4, 2025
pmattmann
force-pushed
the
feature/perf-camp-collaboration-item-endpoint
branch
from
a39f14c to
7cd5d23
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a single
CampCollaborationdoes not always seem performant - but is used very often.I think, we don't need to embed the
Campthere.When a single
CampCollaborationis loaded, theCampis probably already in the cache.