Conversation
carlobeltrame
force-pushed
the
activity-filter-counts
branch
from
f890b7f to
5d3af14
Compare
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
left a comment
manuelmeister
left a comment
There was a problem hiding this comment.
Nice! Good idea
I'm not sure about the visual design.
Maybe this could be "decluttered" with some minor visual clues:
But I can test this in a separate PR.
carlobeltrame
force-pushed
the
activity-filter-counts
branch
from
0ef6eb3 to
1a082dc
Compare
Your version looks so much better! I tried to replicate it. I didn't manage to get a satisfying border, I had to use Anyways, have a look and feel free to improve the CSS or merge if ready. |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
@carlobeltrame can you have a look at it again? I tried to solve it using a component. |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
This is in anticipation of being able to use the same filtering logic in the prints in the future, e.g. to filter the printed schedule entries in a camp programme.
We ignore the error case when the filter object contains something other than an array in the responsible key for now. Since it throws an error, this should quickly surface during development if anyone uses it wrongly, or at least we will see it in sentry.
carlobeltrame
force-pushed
the
activity-filter-counts
branch
from
2b825cf to
a0ff737
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
3 participants
Adds counters indicating the number of results belonging to each filter option.
The counters adapt when more filters are added.
There is some complexity due to the different filter behaviours (AND vs OR, exclusive none, single vs. multiple), but I think I got the most intuitive version down for each filter.
Works both on the dashboard and on the picasso.
Also fixes #4951, and I moved the filtering logic to common, because of the following feature request: "Druckfilter (z.B. nur Blöcke wo ich Verantwortlich bin)". This PR is incidentally a first step in this direction.