Skip to content

Update react-pdf packages to v4#7404

Merged
carlobeltrame merged 4 commits intoecamp:develfrom
carlobeltrame:update-react-pdf-packages
May 24, 2025
Merged

Update react-pdf packages to v4#7404
carlobeltrame merged 4 commits intoecamp:develfrom
carlobeltrame:update-react-pdf-packages

Conversation

@carlobeltrame
Copy link
Member

Fixes #7242
Fixes #7243
Fixes #7245

This was a lot easier than expected...

@carlobeltrame carlobeltrame requested a review from a team May 9, 2025 18:55
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label May 9, 2025
@github-actions
Copy link

github-actions bot commented May 9, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister
Copy link
Member

Why did you have to change the line height?

@carlobeltrame
Copy link
Member Author

carlobeltrame commented May 9, 2025

Why did you have to change the line height?

Behaviour seems to have changed in diegomura/react-pdf#2952 and/or diegomura/react-pdf#2773. I only changed it so it looks the same as before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cateogry text labels are not vertically centered anymore:

Bildschirmfoto 2025-05-18 um 16 51 49

Copy link
Member Author

@carlobeltrame carlobeltrame May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 38219b9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the line height is too high (on dev it is too narrow)
Bildschirmfoto 2025-05-18 um 16 58 54

Copy link
Member Author

@carlobeltrame carlobeltrame May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 38219b9

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I think only the category labels and the picasso day header look different.

@carlobeltrame carlobeltrame force-pushed the update-react-pdf-packages branch from 2137de8 to 87b2a17 Compare May 20, 2025 11:59
@carlobeltrame
Copy link
Member Author

Force pushed only to rebase because of merge conflicts in package.json and package-lock files

@carlobeltrame carlobeltrame force-pushed the update-react-pdf-packages branch from 87b2a17 to be08775 Compare May 20, 2025 17:57
@carlobeltrame carlobeltrame force-pushed the update-react-pdf-packages branch 2 times, most recently from f431233 to 38219b9 Compare May 20, 2025 18:15
@carlobeltrame carlobeltrame force-pushed the update-react-pdf-packages branch from 8955199 to 3eb3ded Compare May 24, 2025 10:47
@carlobeltrame carlobeltrame dismissed manuelmeister’s stale review May 24, 2025 10:48

Fixed the concerns. Besides, printing emoji is currently broken, and this PR fixes it. So I'm merging this to make sure it is deployed at the next possibility.

@carlobeltrame carlobeltrame enabled auto-merge May 24, 2025 10:48
@carlobeltrame carlobeltrame added this pull request to the merge queue May 24, 2025
Merged via the queue into ecamp:devel with commit 4243085 May 24, 2025
46 of 49 checks passed
@carlobeltrame carlobeltrame deleted the update-react-pdf-packages branch May 24, 2025 11:46
@carlobeltrame carlobeltrame mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants