Skip to content

Comments

Font size / page size setting for printing#8035

Merged
carlobeltrame merged 5 commits intoecamp:develfrom
carlobeltrame:print-font-size
Jan 27, 2026
Merged

Font size / page size setting for printing#8035
carlobeltrame merged 5 commits intoecamp:develfrom
carlobeltrame:print-font-size

Conversation

@carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Aug 26, 2025

Fixes #4650
image

A5 / A6 (bigger relative font size): Nuxt A5 Client A5
A4 / A5 (normal, same as on prod): Nuxt A4 Client A4
A4 / A3 (smaller relative font size): Nuxt A3 Client A3

Please feedback on:

  • UI design of the new option
  • Currently, we use A4 page sizes but many users print this on A5. I took the easy way out and left the page size default at A4 (so I don't have to change all font sizes in both print) and just labeled it as "Normal (for printing on A4 or A5)" in the UI. So when the user selects the font size "Bigger (for printing on A6)", the PDF actually uses a page size of A5, and we rely on the users' printers to scale this down. Is this fine? Do users think more in terms of page size or in terms of font size? Should I do the tedious work and change all font sizes in both prints, so that we can be honest to the users?
  • Any bugs in the pdfs. I already had to adjust the picasso time column font size in nuxt print and the auto-scaling font size on picasso schedule entries in client print already.

@carlobeltrame carlobeltrame requested a review from a team August 26, 2025 10:58
@carlobeltrame carlobeltrame force-pushed the print-font-size branch 2 times, most recently from ae26596 to c749615 Compare August 26, 2025 11:11
@BacLuc
Copy link
Contributor

BacLuc commented Aug 26, 2025

The space problem for small blocks get worse on the picasso:

Nuxt A5:
image

And the 07:00 is over the line.

If for whatever reason you use 2 zeros for the relative time from block start, it always wraps:
image
I didn't write many blocks who were longer than 10h...?
But the problem persist for people who use absolute times.

Here it is completely off:
image

Material list looks good:
image

ThematicArea looks good:
image

Client A5
Picasso looks good:
image

Here the user can use 2 digit hours in the block:
image

A3:

I don't know what you would want to print on A3, maybe the picasso?
This works, looks a little empty.

UI Design:
Good that it's hidden and does not clutter the ui for not advanced users.
Not so discoverable...but you have to weigh the 2 options.

},
index: { type: Number, required: true },
filter: { type: Object, default: () => ({}) },
pageSize: { type: String, default: 'a4' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:
In clientprint its 'A4', here 'a4'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually intentional. In nuxt print, a4 is used as a CSS class name, and those are usually lowercase. In client print, A4 needs to be passed into the <Page> element, and it expects it to be uppercase.

@BacLuc
Copy link
Contributor

BacLuc commented Aug 26, 2025

What we also have to discuss:

How much value do we get vs additional maintenance effort?

Do we need tests for the other font sizes?
How do we test the other font sizes?

How much priority does it get when it breaks?

@BacLuc BacLuc requested a review from a team August 26, 2025 19:44
@carlobeltrame
Copy link
Member Author

carlobeltrame commented Aug 27, 2025

The space problem for small blocks get worse on the picasso

True, but if you are using this advanced feature, you probably can also set the picasso to portrait mode and maybe even split it in two parts using the date filters, so it's less of a problem.

And the 07:00 is over the line.

Fixed in 10724c5

I don't know what you would want to print on A3, maybe the picasso?
This works, looks a little empty.

How much value do we get vs additional maintenance effort?

I could also imagine dropping the A3 option, and just supporting the A6 one for now. I agree A4/A3 is only useful for the picasso, if at all. It does improve the "space problem for small blocks" which you mention on the A6 version, but nobody has explicitely asked for reducing the font size as far as I am aware (although when users claim they can create a better readable picasso in excel, this usually just boils down to a smaller font size).

I implemented this because I see the A6 variant as a valid use case for which we can't provide any workarounds at the moment. And if it's just setting the page size plus 1-2 workarounds for the smaller paper size, I feel like the maintenance burden is not so high.

Do we need tests for the other font sizes? How do we test the other font sizes?

I now added basic e2e tests just checking for the number of pages in the A6 variant. 28461de The e2e tests turned out to be extremely flaky in firefox for some reason... I removed them again and added snapshot tests in the pdf module (9c6cda3). In print, we don't have any logic tests at all so far...

@carlobeltrame carlobeltrame force-pushed the print-font-size branch 2 times, most recently from 0898a3a to 9c6cda3 Compare August 27, 2025 11:27
@manuelmeister manuelmeister self-requested a review September 2, 2025 20:00
@usu usu added the deploy! Creates a feature branch deployment for this PR label Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame removed the deploy! Creates a feature branch deployment for this PR label Oct 3, 2025
@carlobeltrame carlobeltrame added the Meeting Discuss Am nächsten Core-Meeting besprechen label Jan 14, 2026
@carlobeltrame carlobeltrame force-pushed the print-font-size branch 2 times, most recently from 110f042 to b17fdfb Compare January 25, 2026 16:35
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Jan 25, 2026
@carlobeltrame carlobeltrame temporarily deployed to feature-branch January 25, 2026 18:06 — with GitHub Actions Inactive
@carlobeltrame carlobeltrame temporarily deployed to feature-branch January 27, 2026 15:51 — with GitHub Actions Inactive
@carlobeltrame carlobeltrame temporarily deployed to feature-branch January 27, 2026 16:17 — with GitHub Actions Inactive
@manuelmeister
Copy link
Member

Grössere Schrift (optimiert für A6)
Normale Schrift (optimiert für A4 oder A5)

@carlobeltrame carlobeltrame removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Jan 27, 2026
@carlobeltrame carlobeltrame temporarily deployed to feature-branch January 27, 2026 19:23 — with GitHub Actions Inactive
@carlobeltrame carlobeltrame added this pull request to the merge queue Jan 27, 2026
Merged via the queue into ecamp:devel with commit 87a71cd Jan 27, 2026
38 of 39 checks passed
@carlobeltrame carlobeltrame deleted the print-font-size branch January 27, 2026 19:36
This was referenced Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Print Layout for small paper formats

4 participants