Tell Vue it's fine to admit errors, we can handle it#8128
Merged
carlobeltrame merged 1 commit intoecamp:develfrom Sep 6, 2025
Merged
Conversation
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
approved these changes
Sep 6, 2025
simfeld
approved these changes
Sep 6, 2025
This was referenced Oct 3, 2025
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the solution to the second detailed problem in #8126. Please merge this together with or after #8126, so that client print doesn't stop working due to missing the fix in #8126.
In client print, if an error happens during the Vue rendering, we want that error to be thrown out of the application. The error will then bubble up to the top level of the worker thread, be caught and relayed by Comlink and then in the main thread reported to Sentry and an error indicator displayed to the user.
However, Vue 3 by default catches all errors and logs them to the console, because normally a Vue app isn't embedded inside of another app. We now explicitely tell Vue to pass errors on without swallowing them.
I tested this locally with an error in a setup script and an error in a computed. Will try to test it on the feature branch deployment too, for a more realistic simulation of production.