Conversation
mnonnenmacher
requested review from
MarcelBochtler,
bs-ondem,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
mnonnenmacher
force-pushed
the
fix-publishing
branch
from
ab15a07 to
0d4b532
Compare
buildSrc/src/main/kotlin/ort-server-kotlin-jvm-application-conventions.gradle.kts
Show resolved
Hide resolved
Enforce the Kotlin version only for application modules as only for those it is important that the Kotlin version is aligned on the runtime classpath. This is a fixup for 764f858. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
Stop publishing Maven artifacts for application modules, as those modules are not supposed to be used as libraries. This fixes the following error when publishing Maven artifacts: Invalid publication 'maven': - Variant 'runtimeElements' contains a dependency on enforced platform 'org.jetbrains.kotlin:kotlin-bom' In general publishing dependencies to enforced platforms is a mistake: enforced platforms shouldn't be used for published components because they behave like forced dependencies and leak to consumers. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
mnonnenmacher
force-pushed
the
fix-publishing
branch
from
0d4b532 to
bf074c3
Compare
Add a test job that publishes artifacts to the local Maven repository to catch errors like the one fixed in the previous commit early. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
mnonnenmacher
force-pushed
the
fix-publishing
branch
from
bf074c3 to
4e415db
Compare
sschuberth
approved these changes
Feb 10, 2026
sschuberth
reviewed
Feb 10, 2026
| */ | ||
|
|
||
| plugins { | ||
| // Apply precompiled plugins. |
Contributor
There was a problem hiding this comment.
As a follow-up, should applying the application plugin be moved to here?
Contributor
Author
There was a problem hiding this comment.
Good idea, I will take a note to try this.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@mnonnenmacher, many thanks for the fast fix! I assume, there is no way to publish the artifacts for the failed 0.52.0 release, and we would instead create another release, right? |
Contributor
Author
Please just delete the 0.52.0 tag and create it again. The Docker images will be overwritten and because nothing was released to Maven Central yet this also won't be a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.