Update from vscode trace extension - prettier v3.x#3
Merged
Conversation
Small adaptations to root package.json, various tsconfig.json. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Add README under local-libs Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> [traceviewer-react] add missing @types/lodash.debounce dev dependency Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Align eslint config with theia-trace-extension For smoother sharing of the traceviewer-* libraries Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> [traceviewer-*] align code to respect linter and formatter Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> update yarn.lock Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Improved watch mode With a correct tsconfig.json setup, it's possible to watch all the typescript workspaces' code using a single "tsc -b -w", executed at the repo root. It's also necessary to cover webpack where it is used. https://webpack.js.org/configuration/watch Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Update root README Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
When the traceviewer-libs git subtree was initially added, running prettier (yarn format:check) would fail locally. This was since determine to be because this repo here was already pulling a more recent version of "prettier" than the theia extension repo: v3.x vs v2.x. The local version of the subtree already has the libraries' code adapted to pass the check with prettier@3. That version was explicitly added as a devDependency to the traceviewer- react-components library, but for completeness, we now add it to traceviwewer-base as well, to be sure the format check will be identical in both repositories, no matter the version of prettier that may be pulled in the root package.json or other components, in either / both repositories. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
In the subtree README, "git subtree push -p <subtree folder" was documented. Not sure where this came from, but my local git won't accept it, instead expecting: "git subtree push --prefix <subtree folder" Corrected in this commit. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
changed the title
marcdumais-work
deleted the
update-from-vscode-trace-extension_prettier3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Updates "traceviewer-libs" from repo
eclipse-cdt-cloud/vscode-trace-extension. The update contains little changes that were made after the traceviewer libraries were added as a local git subtree:../../../<cfg_file>) and need adjusting for the new library folder that's one level deeper vs before (works as updated in in both theia-trace-extension and vscode-trace-extension)How to test
Confirm that CI passes
Follow-ups
Review checklist