iox-#2434: Remove --//:feature_acl=auto

[lalten]

Notes for Reviewer

Remove --//:feature_acl=auto as it breaks hermeticity in downstream consumers.
This turns //:feature_acl into a bool setting (ie the functionality is still there!)

Holding off with the changelog commit to avoid merge conflicts

Since

iceoryx/.bazelrc

Line 1 in 2d58766

build --enable_platform_specific_config

is already there we can simply add build:linux --//:feature_acl=True and it will have exactly the same effect when building iceoryx as root repo (i.e. not being used as library)

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Checklist for the PR Reviewer

• Consider a second reviewer for complex new features or larger refactorings
• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Default --//:feature_acl=off #2434

[elBoberido]

I'm not sure I like this approach. It changes the semantics since this file is only respected for the iceoryx repository. For our users that means that ACL is now suddenly deactivated by default. What's wrong with the previous approach?

[lalten]

As mentioned in the ticket, the previous approach caused broken builds in CIs such as ours and the Bazel BCR where libacl is not installed on the host (and should not be).

As you mentioned that Bazel is only really supported from the upcoming 3.0 version I feel this default isn't set in stone, wdyt?

[elBoberido]

It's not set in stone, but since bazel was not supported in v2.0, quite a lot of our users which need bazel are already using v2.95. I know especially about users who are still using the WORKSPACE approach with bazel 6.2, that's why I'm more concerned with that one and I think we didn't silently break anything for them with the recent PRs. This one would be a silent break since libacl would not be used anymore by default.

[lalten]

It could be added to the change log / release notes and then it's not as silent anymore ;)