iox-#1051 Move publish subscribe port type definitions to pub_sub_port_types.hpp #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niveshdandyan
force-pushed
the
iox-1051-pub-sub-port-types
branch
from
c440f1f to
d0f47ea
Compare
Author
|
Eclipse Contributor Agreement has been signed. Requesting ECA revalidation. |
Author
|
Eclipse Contributor Agreement has been signed by the author (niveshdandyan@gmail.com). Please re-run the ECA validation check. |
…t_types.hpp This commit consolidates publish/subscribe port related type definitions into pub_sub_port_types.hpp, following the established pattern of client_server_port_types.hpp. Changes: - Added PublisherChunkQueueData_t, PublisherChunkDistributorData_t, and PublisherChunkSenderData_t type aliases to pub_sub_port_types.hpp - Added SubscriberEvent and SubscriberState enums to pub_sub_port_types.hpp - Updated publisher_port_data.hpp to use types from pub_sub_port_types.hpp instead of defining them locally - Removed redundant includes from publisher_port_data.hpp - Removed TODO comment from subscriber_port_data.hpp and simplified aliases Benefits: - Reduces dependency issues between port data headers - Provides a single point of definition for pub/sub communication types - Improves code organization and discoverability - Consistent with client_server_port_types.hpp pattern Signed-off-by: Nivesh Dandyan <niveshdandyan@gmail.com>
niveshdandyan
force-pushed
the
iox-1051-pub-sub-port-types
branch
from
d0f47ea to
f6e27d6
Compare
elBoberido
reviewed
Feb 3, 2026
Member
elBoberido
left a comment
elBoberido
left a comment
There was a problem hiding this comment.
Thanks for contributing. Just a minor issue with the patch.
Please also be aware that the core team moved the effort to iceoryx2 and there will probably be no further release of iceoryx classic. I hope this does not affect your motivation to contribute to the iceoryx project in general.
Comment on lines
+49
to
+57
| enum class SubscriberEvent : EventEnumIdentifier | ||
| { | ||
| DATA_RECEIVED | ||
| }; | ||
|
|
||
| enum class SubscriberState : StateEnumIdentifier | ||
| { | ||
| HAS_DATA | ||
| }; |
Member
There was a problem hiding this comment.
If this is added here, it needs to be removed from base_subscriber.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates publish/subscribe port related type definitions into
pub_sub_port_types.hpp, following the established pattern ofclient_server_port_types.hpp.Fixes #1051
Changes
pub_sub_port_types.hppPublisherChunkQueueData_t,PublisherChunkDistributorData_t, andPublisherChunkSenderData_ttype aliasesSubscriberEventandSubscriberStateenums (followingClientEvent/ClientStatepattern)publisher_port_data.hpppub_sub_port_types.hppinstead of defining them locallychunk_distributor_data.hpp,chunk_sender_data.hpp,locking_policy.hpp,subscriber_port_data.hpp)subscriber_port_data.hppiox::popo::namespace prefix)Benefits
publisher_port_data.hppno longer depends onsubscriber_port_data.hppclient_server_port_types.hppTesting
Signed-off-by: Nivesh Dandyan niveshdandyan@gmail.com