Add Surefire Provider Classpath to Eclipse test classpath#2116
Draft
Add Surefire Provider Classpath to Eclipse test classpath#2116
Conversation
Test Results 330 files ±0 330 suites ±0 1h 22m 19s ⏱️ + 8m 45s For more details on these failures and errors, see this check. Results for commit f3adca8. ± Comparison against base commit 5beb82e. This pull request removes 10 and adds 11 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Member
Author
|
Probably needs some cleanup in |
Member
|
@kwin can we have a testcase covering this feature? |
Member
Author
|
Instead of polluting the testing classpath one should probably rather extend |
kwin
force-pushed
the
feature/surefire-provider-classpath
branch
from
b6855d9 to
e03d82d
Compare
kwin
force-pushed
the
feature/surefire-provider-classpath
branch
from
f9092af to
8bcf724
Compare
kwin
commented
Jan 14, 2026
| assertFalse(argLine.contains("@{titi.tata}")); // unresolved property is removed | ||
| } | ||
|
|
||
| @Test |
Member
Author
There was a problem hiding this comment.
Move to MavenRuntimeClasspathProviderTest
kwin
force-pushed
the
feature/surefire-provider-classpath
branch
from
8bcf724 to
2036684
Compare
Deprecate duplicate constants (defined in org.eclipse.jdt.core.IClasspathAttribute) This closes #2112
kwin
force-pushed
the
feature/surefire-provider-classpath
branch
from
67a6764 to
f3adca8
Compare
Member
Author
|
@laeubi I cannot reproduce the test issues locally. Any pointers how I can increase logging during CI build within the Eclipse tests? I want to see the DEBUG logs of category |
Member
Author
|
For me there is never any SLF4J provider bound during test execution, probably related to loading order, as the target platform contains some SLF4J provider (logback) and SpiFly as well. |
Member
You mean in the IDE or when running maven? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate duplicate constants (defined in
org.eclipse.jdt.core.IClasspathAttribute)
This closes #2112