MenuItem.setImage() GTK4 fix.

[Theo-Dann-Muirhead-Renesas]

ImageSet() fix for GTK4. #2299
Previously ImageSet() returned null on GTK4, This is an implementation of ImageSet() for GTK4.

To test:

• Ensure GTK4 is forced with "SWT_GTK4 = 1" environment variable in ControlExample.
• Start ControlExample -> Click "Menu" -> Check "Images" -> Click "Create Shell"

If Cascade dropdown has icons then the change is working.

[github-actions]

Test Results

  118 files  ±0    118 suites  ±0   11m 41s ⏱️ +53s
4 583 tests ±0  4 547 ✅ ±0  36 💤 ±0  0 ❌ ±0 
  330 runs  ±0    307 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit d3ad875. ± Comparison against base commit 12ac449.

♻️ This comment has been updated with latest results.

[jonahgraham]

@Theo-Dann-Muirhead-Renesas It looks like some part of your commit may be missing as build fails with:

Error: The method gtk_reorder_child_after(long, long, int) is undefined for the type GTK4

Did you have a change to GTK4.java that should be included here?

[jonahgraham]

The full error is here, quoted below:

Error:  Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.0:compile (default-compile) on project org.eclipse.swt.gtk.linux.ppc64le: Compilation failure: Compilation failure: 
Error:  /home/runner/work/eclipse.platform.swt/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/MenuItem.java:[1065] 
Error:  	GTK4.gtk_reorder_child_after(boxHandle, imageHandle, 0);
Error:  	     ^^^^^^^^^^^^^^^^^^^^^^^
Error:  The method gtk_reorder_child_after(long, long, int) is undefined for the type GTK4
Error:  /home/runner/work/eclipse.platform.swt/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/MenuItem.java:[1095] 
Error:  	GTK4.gtk_box_remove(boxHandle, imageHandle);
Error:  	     ^^^^^^^^^^^^^^
Error:  The method gtk_box_remove(long, long) is undefined for the type GTK4
Error:  /home/runner/work/eclipse.platform.swt/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/MenuItem.java:[1103] 
Error:  	GTK4.gtk_box_remove(boxHandle, imageHandle);
Error:  	     ^^^^^^^^^^^^^^
Error:  The method gtk_box_remove(long, long) is undefined for the type GTK4
Error: [ERROR] 5 problems (3 errors, 2 warnings)
Error:  -> [Help 1]

[Theo-Dann-Muirhead-Renesas]

Yes, I missed that two methods were not originally included

[akurtakov]

Please resolve the conflicts with master.

[akurtakov]

As you can see by the failing check - merge commits are not welcome, so please rebase on master without merge commits.

[akurtakov]

I get a crash here:
(SWT:623314): Gtk-CRITICAL **: 18:01:06.474: gtk_image_set_from_paintable: assertion 'GTK_IS_IMAGE (image)' failed
Exception in thread "main" org.eclipse.swt.SWTError: No more handles
at org.eclipse.swt.SWT.error(SWT.java:4980)
at org.eclipse.swt.SWT.error(SWT.java:4865)
at org.eclipse.swt.SWT.error(SWT.java:4836)
at org.eclipse.swt.widgets.Widget.error(Widget.java:598)
at org.eclipse.swt.widgets.MenuItem._setImage(MenuItem.java:1062)
at org.eclipse.swt.widgets.MenuItem._setEnabledOrDisabledImage(MenuItem.java:990)
at org.eclipse.swt.widgets.MenuItem.setImage(MenuItem.java:1037)
at org.eclipse.swt.examples.controlexample.MenuTab.createButtonSelected(MenuTab.java:97)
at org.eclipse.swt.events.SelectionListener$1.widgetSelected(SelectionListener.java:83)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:286)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5884)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1656)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:5099)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4540)
at org.eclipse.swt.examples.controlexample.ControlExample.main(ControlExample.java:240)

As imageHandle is 0 (checked on line 1060) you clearly can't set it but have to create it first.

[raghucssit]

I get a crash here: (SWT:623314): Gtk-CRITICAL **: 18:01:06.474: gtk_image_set_from_paintable: assertion 'GTK_IS_IMAGE (image)' failed Exception in thread "main" org.eclipse.swt.SWTError: No more handles at org.eclipse.swt.SWT.error(SWT.java:4980) at org.eclipse.swt.SWT.error(SWT.java:4865) at org.eclipse.swt.SWT.error(SWT.java:4836) at org.eclipse.swt.widgets.Widget.error(Widget.java:598) at org.eclipse.swt.widgets.MenuItem._setImage(MenuItem.java:1062) at org.eclipse.swt.widgets.MenuItem._setEnabledOrDisabledImage(MenuItem.java:990) at org.eclipse.swt.widgets.MenuItem.setImage(MenuItem.java:1037) at org.eclipse.swt.examples.controlexample.MenuTab.createButtonSelected(MenuTab.java:97) at org.eclipse.swt.events.SelectionListener$1.widgetSelected(SelectionListener.java:83) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:286) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5884) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1656) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:5099) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4540) at org.eclipse.swt.examples.controlexample.ControlExample.main(ControlExample.java:240)

As imageHandle is 0 (checked on line 1060) you clearly can't set it but have to create it first.

I am still seeing this error..
I took the latest commit of this PR..

[Theo-Dann-Muirhead-Renesas]

My latest push should fix this particular issue but there is another I have found, currently reviewing #2511 to catch up on progress made recently.

[akurtakov]

I guess all the ImageSet() in the commit message should really be setImage(), right ?

[akurtakov]

There are conflicts with master, please always rebase on master before pushing new version.