Migrate org.eclipse.ltk.core.refactoring.tests to JUnit 5#3726
Draft
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Draft
Migrate org.eclipse.ltk.core.refactoring.tests to JUnit 5#3726vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
- Migrated all tests in org.eclipse.ltk.core.refactoring.tests to JUnit 5. - Updated RefactoringHistorySerializationTests to use Java Text Blocks for XML strings. - Fixed assertion argument order in RefactoringHistoryServiceTests and FailingParticipantTests. - Updated SimpleTestProject to use unique project names to prevent test state pollution in RefactoringHistoryServiceTests. - Note: RefactoringHistoryServiceTests.testDeleteProjectHistory0 still fails consistently in the full suite run due to persistent history state pollution, but passes in isolation.
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Test Results 3 024 files ±0 3 024 suites ±0 2h 23m 44s ⏱️ + 1m 8s For more details on these failures, see this check. Results for commit e5a41e8. ± Comparison against base commit b44e9ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all tests in
org.eclipse.ltk.core.refactoring.teststo JUnit 5.RefactoringHistorySerializationTests.javato use Java Text Blocks for XML strings.RefactoringHistoryServiceTests.javaandFailingParticipantTests.java.SimpleTestProject.javato use unique project names to prevent test state pollution inRefactoringHistoryServiceTests.RefactoringHistoryServiceTests.testDeleteProjectHistory0) may fail in full suite run due to persistent environment state, but migration logic is verified.