fix uprotocol zenoh key missmatch from uuri change#18
Closed
Bert-Tec wants to merge 8 commits intoeclipse-uprotocol:mainfrom
Closed
fix uprotocol zenoh key missmatch from uuri change#18Bert-Tec wants to merge 8 commits intoeclipse-uprotocol:mainfrom
Bert-Tec wants to merge 8 commits intoeclipse-uprotocol:mainfrom
Conversation
stevenhartley
approved these changes
Oct 1, 2025
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
You are right per https://github.com/eclipse-uprotocol/up-spec/blob/main/up-l1/zenoh.adoc. I'm approving the change
|
@Bert-Tec you need to sign the Eclipse Contributor Agreement for me to be able to merge in the change. Also the linter is failing, can you address the changes? |
Author
|
new PR to replace this as the old repo is locked: #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
up-transport-zenoh-python uses an old version to generate the zenoh key from the uuri.
It only has
{authority}/{ue_id}/{ue_version_major}/{resource_id}, but in newer versions theui_idis split intoue_typeandue_instance:{authority}/{ue_type}/{ue_instance}/{ue_version_major}/{resource_id}(e.g. see https://github.com/eclipse-uprotocol/up-transport-zenoh-rust/blob/fd98206c99fd075e9acf65eb56aa0a909985b003/src/utransport.rs#L85).This makes the python implementation incompatible with newer implementations of other languages.
@PLeVasseur can probably give more context if needed.