Skip to content

Conversation

@yellowhatter
Copy link
Contributor

@yellowhatter yellowhatter commented Dec 23, 2025

compile with -F "uring"


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: enhancement

✨ Enhancement Requirements

Since this PR enhances existing functionality:

  • Enhancement scope documented - Clear description of what is being improved
  • Minimum necessary code - Implementation is as simple as possible, doesn't overcomplicate the system
  • Backwards compatible - Existing code/APIs still work unchanged
  • No new APIs added - Only improving existing functionality
  • Tests updated - Existing tests pass, new test cases added if needed
  • Performance improvement measured - If applicable, before/after metrics provided
  • Documentation updated - Existing docs updated to reflect improvements
  • User impact documented - How users benefit from this enhancement

Remember: Enhancements should not introduce new APIs or breaking changes.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@yellowhatter yellowhatter self-assigned this Dec 23, 2025
@yellowhatter yellowhatter added the enhancement Existing things could work better label Dec 23, 2025
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 62.32558% with 243 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.94%. Comparing base (0682bc5) to head (2a1989b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
commons/zenoh-uring/src/reader.rs 74.61% 116 Missing ⚠️
commons/zenoh-uring/src/writer.rs 0.00% 78 Missing ⚠️
commons/zenoh-uring/src/batch_arena.rs 38.63% 27 Missing ⚠️
commons/zenoh-uring/src/page_arena.rs 50.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
- Coverage   72.10%   71.94%   -0.16%     
==========================================
  Files         390      394       +4     
  Lines       62819    63457     +638     
==========================================
+ Hits        45293    45654     +361     
- Misses      17526    17803     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Existing things could work better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant