Skip to content

Storing state stored via business repository #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgafka merged 2 commits into from
Dec 22, 2024
Merged

Storing state stored via business repository #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de33204
Storing state stored via business repository
dgafka Dec 22, 2024
f521068
Fixes
dgafka Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 45 additions & 44 deletions packages/Ecotone/src/Modelling/Config/AggregrateHandlerModule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,36 @@ private function registerAggregateCommandHandler(Configuration $configuration, I
}
}

private function registerSaveAggregate(ClassDefinition $aggregateClassDefinition, Configuration $configuration, MessageProcessorActivatorBuilder $chainMessageHandlerBuilder, InterfaceToCallRegistry $interfaceToCallRegistry, BaseEventSourcingConfiguration $baseEventSourcingConfiguration, string $inputChannelName): void
{
/** @TODO do not require method name in save service */
$methodName = $aggregateClassDefinition->getPublicMethodNames() ? $aggregateClassDefinition->getPublicMethodNames()[0] : '__construct';

$saveAggregateBuilder = $chainMessageHandlerBuilder
->chain(ResolveAggregateEventsServiceBuilder::create($aggregateClassDefinition, $methodName, $interfaceToCallRegistry))
->chain(
SaveAggregateServiceBuilder::create(
$aggregateClassDefinition,
$methodName,
$interfaceToCallRegistry,
$baseEventSourcingConfiguration
)
->withAggregateRepositoryFactories($this->aggregateRepositoryReferenceNames)
)
;

if ($configuration->isRunningForTest()) {
$saveAggregateBuilderWithTestState = clone $saveAggregateBuilder;
$configuration->registerMessageHandler(
$saveAggregateBuilderWithTestState
->withInputChannelName($saveAggregateBuilderWithTestState->getInputMessageChannelName() . '.test_setup_state')
);
}

$saveAggregateBuilder = $saveAggregateBuilder->chain(PublishAggregateEventsServiceBuilder::create($aggregateClassDefinition, $methodName));
$configuration->registerMessageHandler($saveAggregateBuilder);
}

private function registerAggregateQueryHandler(AnnotatedFinding $registration, InterfaceToCallRegistry $interfaceToCallRegistry, ParameterConverterAnnotationFactory $parameterConverterAnnotationFactory, Configuration $configuration): void
{
/** @var QueryHandler $annotationForMethod */
Expand Down Expand Up @@ -348,26 +378,6 @@ private function registerAggregateQueryHandler(AnnotatedFinding $registration, I
);
}

public function getModulePackageName(): string
{
return ModulePackageList::CORE_PACKAGE;
}

public static function getRegisterAggregateLoadRepositoryInputChannel(string $className, bool $allowNulls): string
{
return self::getAggregateRepositoryInputChannel($className, '.will_load', false, $allowNulls);
}

public static function getRegisterAggregateSaveRepositoryInputChannel(string $className): string
{
return self::getAggregateRepositoryInputChannel($className, '.will_save', true, false);
}

public static function getAggregateRepositoryInputChannel(string $className, string $methodName1, bool $isSave, bool $canReturnNull): string
{
return $className . $methodName1 . ($isSave ? '.save' : '.load' . ($canReturnNull ? '.nullable' : ''));
}

private function registerLoadAggregate(ClassDefinition $aggregateClassDefinition, bool $canReturnNull, Configuration $configuration, MessageProcessorActivatorBuilder $chainMessageHandlerBuilder, InterfaceToCallRegistry $interfaceToCallRegistry): void
{
/** @TODO do not require method name in save service */
Expand All @@ -384,34 +394,24 @@ private function registerLoadAggregate(ClassDefinition $aggregateClassDefinition
);
}

private function registerSaveAggregate(ClassDefinition $aggregateClassDefinition, Configuration $configuration, MessageProcessorActivatorBuilder $chainMessageHandlerBuilder, InterfaceToCallRegistry $interfaceToCallRegistry, BaseEventSourcingConfiguration $baseEventSourcingConfiguration, string $inputChannelName): void
public function getModulePackageName(): string
{
/** @TODO do not require method name in save service */
$methodName = $aggregateClassDefinition->getPublicMethodNames() ? $aggregateClassDefinition->getPublicMethodNames()[0] : '__construct';
return ModulePackageList::CORE_PACKAGE;
}

$saveAggregateBuilder = $chainMessageHandlerBuilder
->chain(ResolveAggregateEventsServiceBuilder::create($aggregateClassDefinition, $methodName, $interfaceToCallRegistry))
->chain(
SaveAggregateServiceBuilder::create(
$aggregateClassDefinition,
$methodName,
$interfaceToCallRegistry,
$baseEventSourcingConfiguration
)
->withAggregateRepositoryFactories($this->aggregateRepositoryReferenceNames)
)
;
public static function getRegisterAggregateLoadRepositoryInputChannel(string $className, bool $allowNulls): string
{
return self::getAggregateRepositoryInputChannel($className, '.will_load', false, $allowNulls);
}

if ($configuration->isRunningForTest()) {
$saveAggregateBuilderWithTestState = clone $saveAggregateBuilder;
$configuration->registerMessageHandler(
$saveAggregateBuilderWithTestState
->withInputChannelName($saveAggregateBuilderWithTestState->getInputMessageChannelName() . '.test_setup_state')
);
}
public static function getRegisterAggregateSaveRepositoryInputChannel(string $className): string
{
return self::getAggregateRepositoryInputChannel($className, '.will_save', true, false);
}

$saveAggregateBuilder = $saveAggregateBuilder->chain(PublishAggregateEventsServiceBuilder::create($aggregateClassDefinition, $methodName));
$configuration->registerMessageHandler($saveAggregateBuilder);
public static function getAggregateRepositoryInputChannel(string $className, string $methodName1, bool $isSave, bool $canReturnNull): string
{
return $className . $methodName1 . ($isSave ? '.save' : '.load' . ($canReturnNull ? '.nullable' : ''));
}

private function initialization(Configuration $messagingConfiguration): void
Expand Down Expand Up @@ -526,6 +526,7 @@ public function registerBusinessRepositories(InterfaceToCallRegistry $interfaceT
$gatewayParameterConverters = [
GatewayHeaderBuilder::create($interface->getFirstParameter()->getName(), AggregateMessage::CALLED_AGGREGATE_OBJECT),
GatewayHeaderBuilder::create($interface->getFirstParameter()->getName(), AggregateMessage::RESULT_AGGREGATE_OBJECT),
GatewayPayloadBuilder::create($interface->getFirstParameter()->getName())
Copy link
Member Author

@dgafka dgafka Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was missing.

];
}
} else {
Expand Down
5 changes: 1 addition & 4 deletions packages/Ecotone/tests/Modelling/Unit/LoadAggregateServiceBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,7 @@ public function test_fetch_nulls_on_non_null_business_repository()
$repository->get(123);
}

/**
* @TODO
*/
public function todo_test_storing_standard_aggregate_via_business_repository(): void
public function test_storing_standard_aggregate_via_business_repository(): void
{
$ecotoneLite = EcotoneLite::bootstrapFlowTesting(
[Appointment::class, AppointmentStandardRepository::class, AppointmentRepositoryInterface::class],
Expand Down
Loading