Skip to content

amqp - message is delivered on lost hearbeat#431

Merged
dgafka merged 8 commits intomainfrom
fix/message-is-delivered-on-lost-hearbeat
Jan 26, 2025
Merged

amqp - message is delivered on lost hearbeat#431
dgafka merged 8 commits intomainfrom
fix/message-is-delivered-on-lost-hearbeat

Conversation

@dgafka
Copy link
Member

@dgafka dgafka commented Jan 25, 2025

Why is this change proposed?

image

Description of Changes

Pull Request Contribution Terms

  • I have read and agree to the contribution terms outlined in CONTRIBUTING.

@lifinsky
Copy link
Contributor

@dgafka https://www.rabbitmq.com/docs/confirms#publisher-confirms
Great for outbox without strong alternatives. Thanks.

@dgafka dgafka merged commit 06a7f25 into main Jan 26, 2025
66 checks passed
@dgafka dgafka deleted the fix/message-is-delivered-on-lost-hearbeat branch January 26, 2025 21:06
->withExtensionObjects([
AmqpBackedMessageChannelBuilder::create($queueName)
->withDeliveryGuarantee(false),
->withPublisherAcknowledgments(false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withPublisherConfirms maybe better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants