feat: prevent global mode in async tests#110
Merged
edgurgel merged 1 commit intoedgurgel:mainfrom Jan 17, 2026
Merged
Conversation
Similar to what Mox does, prevent this footgun by raising an exception
edgurgel
force-pushed
the
feat/prevent-global-mimic-on-async-false
branch
from
4697eee to
4e344e3
Compare
jimsynz
pushed a commit
to jimsynz/pca9641
that referenced
this pull request
Jan 22, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mimic](https://hex.pm/packages/mimic) ([source](https://github.com/edgurgel/mimic)) | dev | major | `~> 1.12` → `~> 2.0` | --- ### Release Notes <details> <summary>edgurgel/mimic (mimic)</summary> ### [`v2.3.0`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#230-2026-01-17) [Compare Source](edgurgel/mimic@v2.2.0...v2.3.0) - fix: namespace auto setup verify\_on\_exit! by [@​PragTob](https://github.com/PragTob) in [#​111](edgurgel/mimic#111) - feat: prevent global mode in async tests by [@​rbino](https://github.com/rbino) in [#​110](edgurgel/mimic#110) ### [`v2.2.0`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#220-2025-11-18) [Compare Source](edgurgel/mimic@v2.1.1...v2.2.0) - Add elixir 1.19.x compatibility by [@​Geekfish](https://github.com/Geekfish) in [#​107](edgurgel/mimic#107) ### [`v2.1.1`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#211-2025-09-20) [Compare Source](edgurgel/mimic@v2.1.0...v2.1.1) - Don't remove behaviour\_info/1 from behaviour modules by [@​escobera](https://github.com/escobera) in [#​105](edgurgel/mimic#105) ### [`v2.1.0`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#210-2025-08-31) [Compare Source](edgurgel/mimic@v2.0.2...v2.1.0) - feat: Usage rules by [@​pcharbon70](https://github.com/pcharbon70) in [#​102](edgurgel/mimic#102) - fix: define replaced Elixir module macros using defmacro by [@​yastanotheruser](https://github.com/yastanotheruser) in [#​104](edgurgel/mimic#104) ### [`v2.0.2`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#202-2025-08-12) [Compare Source](edgurgel/mimic@v2.0.1...v2.0.2) - fix: Mimic.Module compilation when no options are stored. [#​101](edgurgel/mimic#101) ### [`v2.0.1`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#201-2025-08-08) [Compare Source](edgurgel/mimic@v2.0.0...v2.0.1) - Bump `ham` requirement ### [`v2.0.0`](https://github.com/edgurgel/mimic/blob/HEAD/CHANGELOG.md#200-2025-07-13) [Compare Source](edgurgel/mimic@v1.12.0...v2.0.0) #### Breaking changes The code below would call the original `Calculator.add/2` when all expectations were fulfilled. ```elixir Calculator |> expect(:add, fn _, _ -> :expected1 end) |> expect(:add, fn _, _ -> :expected2 end) assert Calculator.add(1, 1) == :expected1 assert Calculator.add(1, 1) == :expected2 assert Calculator.add(1, 1) == 2 ``` Now with Mimic 2 this will raise: ```elixir Calculator |> expect(:add, fn _, _ -> :expected1 end) |> expect(:add, fn _, _ -> :expected2 end) assert Calculator.add(1, 1) == :expected1 assert Calculator.add(1, 1) == :expected2 Calculator.add(1, 1) # Will raise error because more than 2 calls to Calculator.add were made and there is no stub # ** (Mimic.UnexpectedCallError) Calculator.add/2 called in process #PID<.*> but expectations are already fulfilled ``` If there is a stub the stub will be called instead. This behaviour is the same as before. ```elixir Calculator |> expect(:add, fn _, _ -> :expected1 end) |> expect(:add, fn _, _ -> :expected2 end) |> stub(:add, fn _, _ -> :stub end) assert Calculator.add(1, 1) == :expected1 assert Calculator.add(1, 1) == :expected2 assert Calculator.add(1, 1) == :stub ``` Which means that if someone wants to keep the original behaviour on Mimic 1.\* just do the following: ```elixir Calculator |> expect(:add, fn _, _ -> :expected1 end) |> expect(:add, fn _, _ -> :expected2 end) |> stub(:add, fn x, y -> call_original(Calculator, :add, [x, y]) end) assert Calculator.add(1, 1) == :expected1 assert Calculator.add(1, 1) == :expected2 assert Calculator.add(1, 1) == 2 ``` This way once all expectations are fulfilled the original function is called again. ### [`v1.12.0`](https://github.com/edgurgel/mimic/releases/tag/v1.12.0): Mimic 1.12.0 [Compare Source](edgurgel/mimic@v1.11.2...v1.12.0) #### What's Changed - Mimic.calls/3 to list args from each call by [@​brentjanderson](https://github.com/brentjanderson) in [#​94](edgurgel/mimic#94) #### New Contributors - [@​brentjanderson](https://github.com/brentjanderson) made their first contribution in [#​94](edgurgel/mimic#94) **Full Changelog**: <edgurgel/mimic@v1.11.2...v1.12.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTYuMiIsInVwZGF0ZWRJblZlciI6IjQyLjg3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlIl19--> Reviewed-on: https://harton.dev/james/pca9641/pulls/116 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what Mox does, prevent this footgun by raising an exception