Skip to content

add text description when clicking on image in reader#3357

Open
arthur-lemeur wants to merge 7 commits intodevelopfrom
feat/add-textdescription-reader-image
Open

add text description when clicking on image in reader#3357
arthur-lemeur wants to merge 7 commits intodevelopfrom
feat/add-textdescription-reader-image

Conversation

@arthur-lemeur
Copy link
Collaborator

@arthur-lemeur arthur-lemeur commented Jan 19, 2026

Fixes ##3139

@gautierchomel
Copy link
Member

gautierchomel commented Feb 5, 2026

Great!
To be discussed:

  • "altText": "Alternative text" not being used, it can be commented.
  • Instead, the Summary of the detail element is filled with the content of the alt argument. That's great as alt would be very hard to explain in an human understandable way. But we should remember that no limit exist on the lenght of alt
  • Also, the Summary should also describe the action that it triggers.
  • If no alt or empty alt, then a generic "about": "About this image" is used. Correctly authored epub should never have content here, so in case of empty alt we would probably end up with a "About this image" that will contain nothing.

Because of that I suggest to use a generic descriptive label (Expand or collapse textual descriptions). for the Summary and place (if it exists) the alt as the first p under.

@danielweck
Copy link
Member

could you please undo your changes to package-lock.json?

@arthur-lemeur arthur-lemeur force-pushed the feat/add-textdescription-reader-image branch from bd6fb58 to 4634487 Compare February 5, 2026 16:34
@gautierchomel
Copy link
Member

Apologises for mis manipulation ending with commit and revert commit being pushed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants