fix: detection of CORS preflight requests for skipCorsPreflight option#8
Merged
eelkevdbos merged 1 commit intoeelkevdbos:mainfrom Jan 17, 2025
Merged
fix: detection of CORS preflight requests for skipCorsPreflight option#8eelkevdbos merged 1 commit intoeelkevdbos:mainfrom
skipCorsPreflight option#8eelkevdbos merged 1 commit intoeelkevdbos:mainfrom
Conversation
2 tasks
Owner
|
Thanks, this looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like this checker was checking the incorrect request header.
Cross-Origin-Request-Methoddoesn't seem to be included in CORS preflight requests, so I changed it to Access-Control-Request-Method and theskipCorsPreflightworks now./** * Checks if the request is a CORS preflight request */ function isCORSPreflightRequest(request: Request) { return ( request.method === "OPTIONS" && request.headers.has("Origin") && - request.headers.has("Cross-Origin-Request-Method") + request.headers.has("Access-Control-Request-Method") ) }