This repository was archived by the owner on Jul 21, 2020. It is now read-only.
Enable packaged installation using setup.py#18
Open
jhansche wants to merge 1 commit intoegirault:masterfrom
Open
Enable packaged installation using setup.py#18jhansche wants to merge 1 commit intoegirault:masterfrom
jhansche wants to merge 1 commit intoegirault:masterfrom
Conversation
This also removes the dependency on config.py from googleplay.py. The reason for that is because GooglePlayAPI constructor already accepts values for the fields being obtained via config.py, and only the driver wrapper scripts pass in those values from config.py. By removing config.py dependency, it allows the package to be installed via easy_install, which will only install the googleplay and googleplay_pb2 modules to the system, avoiding the need to introduce any of the other scripts. Change-Id: Ice195c62369000ecd2778fd5cbf6714601ae338f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the dependency on config.py from googleplay.py. The
reason for that is because GooglePlayAPI constructor already accepts
values for the fields being obtained via
config.py, and only the driverwrapper scripts pass in those values from
config.py.By removing
config.pydependency, it allows the package to be installedvia
easy_install, which will only install thegoogleplayandgoogleplay_pb2modules to the system, avoiding the need to introduce anyof the other scripts.