Merged
Conversation
Owner
|
Looks good by inspection, I think I will test this next week finally and probably merge then. |
Contributor
Author
Thanks. It seems we need to increase the value of pylint's max-args rule to 8. |
Owner
Yes, feel free to add: diff --git a/setup.cfg b/setup.cfg
index 7a16eef..bfd46ca 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -66,7 +66,8 @@ good-names=i,QUEUED_EVENTS_BATCH_SIZE
[pylint.design]
min-public-methods=0
max-attributes=15
-max-args=7
+max-args=8
+max-positional-arguments=13
max-parents=9
[pylint.exceptions]and ignore the other errors which are unrelated to this PR. |
eht16
reviewed
Jan 18, 2025
eht16
reviewed
Jan 18, 2025
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to set url path for the HttpTransport; but with current url implementation, that's not possible.
Here is a quick fix for that.