fix: use find_if instead of iterator loops with break #2383
+27
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors a few remaining “iterator loop + break” patterns into std::find_if-based lookups now that podio collections support this more cleanly, and removes outdated commented examples.
Changes:
- Replace manual association-search loops with
std::find_ifin scattered-electron association logic. - Update beam-particle selection helpers in
Beam.hto usestd::find_if. - Remove a large block of obsolete commented-out iteration examples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/algorithms/reco/ScatteredElectronsTruth.cc |
Uses std::find_if to locate the truth↔reco association instead of a manual loop. |
src/algorithms/reco/InclusiveKinematicsElectron.cc |
Removes outdated commented code demonstrating older iteration patterns. |
src/algorithms/reco/HadronicFinalState.cc |
Uses std::find_if for truth↔reco association lookup instead of a manual loop. |
src/algorithms/reco/Beam.h |
Refactors “find first with PDG/status” helpers to std::find_if and adds <algorithm>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit e4db126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Needs:
In a few places, due to historical limitations of podio collections, we were still using iterator-based loops with tests and early break to do things that are more nicely done with
find_ifnowadays. This PR introduces thefind_ifbased approach in a few cases, and removes a comment block complaints about all that used to not work...What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.