fix: pull_request trigger for branches into master#85
Open
fix: pull_request trigger for branches into master#85
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a workflow trigger issue that was causing empty merge request tags to be pushed to EICweb. By restricting the push trigger to only the master branch and adding a pull_request trigger for PRs targeting master, the workflow now only runs when proper PR context is available, preventing empty tags from being created.
Key Changes
- Added
pull_requesttrigger filtered to PRs targeting themasterbranch - Restricted
pushtrigger to only fire on pushes to themasterbranch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR should avoid the empty mr tags being pushed from eicweb due to the trigger on push instead of pull_request.