Fix a problem with ETOS base test runner validation#126
Merged
t-persson merged 2 commits intoeiffel-community:mainfrom Jan 8, 2026
Merged
Fix a problem with ETOS base test runner validation#126t-persson merged 2 commits intoeiffel-community:mainfrom
t-persson merged 2 commits intoeiffel-community:mainfrom
Conversation
t-persson
requested review from
andmat900 and
fredjn
and removed request for
a team
t-persson
force-pushed
the
fix-etos-base-testrunner
branch
from
8986d69 to
59509b1
Compare
Collaborator
Author
|
Rebased |
andmat900
reviewed
Dec 12, 2025
| self.tokens[manifest_url] = { | ||
| "token": response_json.get("token"), | ||
| "expire": time.time() | ||
| + response_json.get("expires_in", 0.0) |
Contributor
There was a problem hiding this comment.
Is it correct to default to 0? Can this be interpreted as "expires immediately" and lead to excessive regeneration of tokens?
Collaborator
Author
There was a problem hiding this comment.
It can indeed be interpreted as "expires immediately". That is the reason for this change.
With this change this token will be used once and removed next iteration
| :param manifest_url: URL the token has been stored for. | ||
| :return: A token or None. | ||
| """ | ||
| self.logger.info("Getting token for %r", manifest_url) |
Contributor
There was a problem hiding this comment.
Is info the right logging level for this purpose?
Collaborator
Author
There was a problem hiding this comment.
I would say so, yes. Considering everything else in this package is info level and they are relevant together
fredjn
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
fixes: eiffel-community/etos#483
Description of the Change
Fixes a problem where if the "expires_in" key is not returned from the container registry, we default to 0 without returning the token causing the token to "expire" and we'll never be able to authenticate.
Fixed this by returning the token after we retrieved it (the behavior we had before) so that it may be used right after.
I also had to add a new header for ghcr otherwise we'd get a 401(or 403 I don't remember).
Added some more debugging information that was helpful during my work on this issue.
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com