Conversation
erickzhao
left a comment
There was a problem hiding this comment.
Please remove the changes to .sha, package-lock.json, and yarn.lock
|
hey @erickzhao , This was my first PR and I mistakenly included changes to to .sha, yarn.lock, and package-lock.json thinking they were necessary, It happened due to running 'npm install' command instead of 'yarn'. |
dsanders11
left a comment
There was a problem hiding this comment.
@GauravKumar17, can you explain why there are so many new files added in this PR?
|
@dsanders11 Thanks for reviewing ! I understand it might look a large addition but after hours of here and there , I came to this solution. |
|
Hey @dsanders11 , don't mind asking but is their any mistake in the PR? If you just give me a review, I will be happy with the learning. |
|
Hey @erickzhao @dsanders11 1! Hope you're doing well. My PR has been waiting for a bit, and I’d really appreciate it if you could review it whenever you get the chance. I’m more than happy to update anything that needs fixing. Thanks a lot! |
Description of Change
Added a warning preamble to the blog post which are more than a year old.
This helps the reader to know that some information on the blog may be outdated.
Main changes are in :
src/theme/BlogPostItem/index.tsx
src/css/custom.scss
Note- Please feel free to review and correct my mistakes, this was my life's first PR.
Checklist
Dark Mode
Light Mode
Closes #857