Open
Conversation
gampleman
reviewed
Sep 6, 2023
| [] -> | ||
| Test.Expectation.fail | ||
| { reason = Invalid EmptyList | ||
| , description = "Expect.oneOf ran out of expectations." |
Contributor
There was a problem hiding this comment.
I think the feedback should be a lot more informative. This doesn't tell you at all how to fix your test.
Author
There was a problem hiding this comment.
@gampleman could you please help provide a solution for that? Would it need to keep track of why all expectations failed and print that?
Contributor
There was a problem hiding this comment.
Although perhaps in a more condensed format? I think there's some experimentation to be done on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
Expect.oneOffunction. This function works similarly toExpect.all, but results in a pass if at least one of the subjects passes the check. If all subjects fail the check it returns a fail.I think the implementation should be okay (I had implemented the same function in my codebase, but without the usage of the internal types). I'm not sure about the tests because I'm having a hard time running the repository tests locally.
Any feedback would be appreciated!