feat: add auto credential option for cloud backends#347
feat: add auto credential option for cloud backends#347thweetkomputer wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| bool enable) | ||
| { | ||
| if (opts) | ||
| reinterpret_cast<KvOptions *>(opts)->cloud_auto_credentials = enable; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 80 characters long [whitespace/line_length] [2]
| { | ||
| if (options_ && options_->cloud_auto_credentials) | ||
| { | ||
| // TODO: extend this to support GCP-native credential sources when |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Auto Credentials Support
keep the existing simple provider path.