Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the NativeAOT-LLVM backend by introducing a new LLVM property and adapting the assembly inspection and publishing behavior accordingly. Key changes include:
- Adding a new required boolean property (LLVM) to toggle the NativeAOT-LLVM behavior.
- Adjusting the file filtering in assembly inspection based on the LLVM flag.
- Updating tests, samples, benchmark data, and documentation to reflect the new LLVM backend support.
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/cs/Bootsharp.Publish/Pack/BootsharpPack.cs | Introduces the LLVM property and adapts file filtering. |
| src/cs/Bootsharp.Publish.Test/Pack/SolutionInspectionTest.cs | Adds tests for behavior when LLVM is enabled. |
| src/cs/Bootsharp.Publish.Test/Pack/PackTest.cs | Updates tests with the new LLVM property. |
| samples/trimming/cs/Program.cs | Updates sample program to wrap log call in Main. |
| samples/trimming/README.md | Updates benchmark table to add .NET 9 LLVM measurements. |
| samples/bench/readme.md | Updates benchmark table columns and values. |
| samples/bench/dotnet-llvm/Program.cs | Minor formatting removal of an extra blank line. |
| samples/bench/bench.mjs | Updates label from ".NET" to ".NET AOT" for clarity. |
| docs/guide/llvm.md | Adds comprehensive documentation for the LLVM backend. |
| docs/guide/build-config.md | Documents the BootsharpLLVM property and its usage. |
| docs/.vitepress/config.ts | Updates navigation to include the new LLVM guide. |
Files not reviewed (7)
- samples/bench/bootsharp/Boot.csproj: Language not supported
- samples/trimming/cs/Trimming.csproj: Language not supported
- src/cs/Bootsharp/Bootsharp.csproj: Language not supported
- src/cs/Bootsharp/Build/Bootsharp.props: Language not supported
- src/cs/Bootsharp/Build/Bootsharp.targets: Language not supported
- src/cs/Directory.Build.props: Language not supported
- src/js/test/cs/Test/Test.csproj: Language not supported
| } | ||
|
|
||
| [Fact] | ||
| public void DoesntIgnoreAssembliesWhenLLVM () |
There was a problem hiding this comment.
[nitpick] Consider using the correct contraction "Doesn't" for better readability in the method name.
There was a problem hiding this comment.
[nitpick] Consider using the correct contraction "Doesn't" for better readability in the method name.
Oh my dear AI overlord, I'd love to. But guess what happens if I use ' for an identifier in C#?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1636 1640 +4
Branches 283 284 +1
=========================================
+ Hits 1636 1640 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that you may still need |
Yeah, I have that when Thanks! |
https://sharp.elringus.com/guide/llvm
resolves #154