Draft
Conversation
Contributor
|
looks like needs rebase |
igordayen
reviewed
Feb 4, 2026
Contributor
igordayen
left a comment
There was a problem hiding this comment.
massive change on pom version can be most likely avoided with proper rebase in place.
please share PR with chat-store to assess cross-repos interdependencies , if still any. thanks
Contributor
Author
There was a problem hiding this comment.
Is this comment still relevant after rebase?
embabel-agent-autoconfigure/embabel-agent-netty-client-autoconfigure/pom.xml
Show resolved
Hide resolved
...bel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/SpringContextPlatformServices.kt
Outdated
Show resolved
Hide resolved
embabel-agent-api/src/main/kotlin/com/embabel/chat/ConversationFactoryProvider.kt
Show resolved
Hide resolved
Contributor
|
also: please consider preserving history for cross-repos refactoring |
6be03a7 to
01d20e2
Compare
bd5ef6c to
95c903f
Compare
johnsonr
reviewed
Feb 6, 2026
Contributor
johnsonr
left a comment
There was a problem hiding this comment.
I think we should at least consider making Message an interface and avoiding the need for StoredMessage.
I'm not sure what the impact of this will be on user code: Probably not too great
igordayen
reviewed
Feb 6, 2026
embabel-agent-api/src/main/kotlin/com/embabel/chat/StoredMessage.kt
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Integrates embabel-chat-store with embabel-agent, establishing agent-api as the source of truth for chat abstractions. This simplifies the dependency graph and enables pluggable conversation storage (in-memory or Neo4j, thus far. More in future).
Changes
Type Hierarchy Simplification
MessageAuthor-Conversationmethods now useUserfromagent.api.identitydirectlyStoredUser(in chat-store) - Interface extendingUserwith Drivine annotations for Neo4j persistenceSimpleStoredUser(in chat-store) - Ready-to-use implementationNew in agent-api
StoredMessageinterface - Storage contract for messagesConversationFactoryinterface - Creates conversations for a store typeConversationFactoryProviderinterface - Aggregates factories by typeConversationStoreTypeenum -IN_MEMORYorSTOREDcontext.ai().conversationFactory(type)Architecture