remove proposal plugins and replace with their corresponding transform#489
Open
mansona wants to merge 2 commits intoemberjs:masterfrom
Open
remove proposal plugins and replace with their corresponding transform#489mansona wants to merge 2 commits intoemberjs:masterfrom
mansona wants to merge 2 commits intoemberjs:masterfrom
Conversation
Member
Author
|
So I noticed when the tests were failing that actually I missed some code that was trying to do smart stuff with ordering the plugins. I have pushed a really naive way to update that code but I have a seeking suspicion that we need to check for both the cases of "proposal" plugins and "transform" plugins, favouring the transform ones but catering for the case that people still use proposal ones 🤔 Can someone with more context in this area let me know if they thing that is required? |
|
I think we can simply remove these plugins as they are part of preset-env v7.14+ (and we list 7.20 as a dependency): #501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin-proposal-class-properties, plugin-proposal-decorators, plugin-proposal-private-methods, and plugin-proposal-private-property-in-object are all now renamed to transform since they are out of proposal stage so this PR updates the dependencies 👍