Fix; renderComponent error: 'Cannot read property of undefined: reading syscall'#20996
Open
NullVoxPopuli wants to merge 2 commits intoemberjs:mainfrom
Conversation
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-01-30 19:10:24.000000000 +0000
+++ pr/./pr-21730181846/out.txt 2026-02-05 22:03:40.000000000 +0000
@@ -1,37 +1,37 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 352.26 KB │ 203.67 KB ║
+║ Total │ 352.26 KB │ 203.55 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.87 KB │ 181.82 KB ║
+║ Total │ 313.87 KB │ 181.79 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.68 KB │ 26.02 KB ║
-║ application │ 13.24 KB │ 8.03 KB ║
+║ -internals │ 36.68 KB │ 25.99 KB ║
+║ application │ 13.24 KB │ 7.99 KB ║
║ array │ 13.05 KB │ 7.54 KB ║
║ canary-features │ 304 B │ 419 B ║
-║ component │ 2.05 KB │ 1.56 KB ║
+║ component │ 2.05 KB │ 1.6 KB ║
║ controller │ 1.96 KB │ 1.45 KB ║
║ debug │ 11.73 KB │ 8.14 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 805 B ║
+║ helper │ 1.08 KB │ 860 B ║
║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 1.22 KB │ 1011 B ║
+║ modifier │ 1.22 KB │ 987 B ║
║ object │ 35.98 KB │ 22.1 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 508 B ║
-║ routing │ 59.37 KB │ 33.92 KB ║
+║ renderer │ 630 B │ 510 B ║
+║ routing │ 59.37 KB │ 33.93 KB ║
║ runloop │ 2.36 KB │ 1.5 KB ║
║ service │ 1 KB │ 858 B ║
-║ template │ 654 B │ 523 B ║
+║ template │ 654 B │ 517 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.33 KB │ 59.68 KB ║
-║ template-factory │ 370 B │ 351 B ║
+║ template-compiler │ 123.33 KB │ 59.61 KB ║
+║ template-factory │ 370 B │ 385 B ║
║ test │ 923 B │ 627 B ║
║ utils │ 4.11 KB │ 3.63 KB ║
║ version │ 55 B │ 131 B ║
@@ -40,19 +40,19 @@
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.38 KB │ 21.85 KB ║
+║ Total │ 38.38 KB │ 21.75 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable │ 2.78 KB │ 1.38 KB ║
║ encoder │ 81 B │ 171 B ║
║ env │ 38 B │ 87 B ║
║ global-context │ 886 B │ 545 B ║
║ manager │ 977 B │ 627 B ║
-║ node │ 175 B │ 244 B ║
+║ node │ 175 B │ 268 B ║
║ opcode-compiler │ 1.11 KB │ 905 B ║
║ owner │ 159 B │ 202 B ║
-║ program │ 252 B │ 333 B ║
+║ program │ 252 B │ 308 B ║
║ reference │ 548 B │ 544 B ║
-║ runtime │ 10.32 KB │ 5.3 KB ║
+║ runtime │ 10.32 KB │ 5.21 KB ║
║ tracking │ 1.34 KB │ 1.18 KB ║
║ util │ 1.94 KB │ 1.6 KB ║
║ validator │ 15.53 KB │ 6.9 KB ║Details
|
cfc8994 to
61f7f8e
Compare
17 tasks
61f7f8e to
1eea38a
Compare
Contributor
Author
|
Normally, I'd say we backport this, but I don't think we can pre-great merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to: #20995
but maybe more representative of real-world usage (renderComponent called from a modifier, or external library, etc).
When the owner is passed to renderComponent, and renderComponent is called multiple times, we get this error: