Skip to content

Add TS keywords to various Route methods and properties where possible #21052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nickschot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add TS keywords to various Route methods and properties where possible #21052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/@ember/routing/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)

_router!: EmberRouter;
declare _topLevelViewTemplate: any;
declare _environment: any;
declare private _environment: any;

constructor(owner?: Owner) {
super(owner);
Expand Down Expand Up @@ -579,15 +579,15 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)

@property _activeQPChanged
*/
_activeQPChanged(qp: QueryParam, value: unknown) {
private _activeQPChanged(qp: QueryParam, value: unknown) {
this._router._activeQPChanged(qp.scopedPropertyName, value);
}

/**
@private
@method _updatingQPChanged
*/
_updatingQPChanged(qp: QueryParam) {
private _updatingQPChanged(qp: QueryParam) {
this._router._updatingQPChanged(qp.urlKey);
}

Expand Down Expand Up @@ -679,7 +679,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
@param {String} controllerPropertyName
@private
*/
serializeQueryParamKey(controllerPropertyName: string) {
private serializeQueryParamKey(controllerPropertyName: string) {
return controllerPropertyName;
}

Expand Down Expand Up @@ -721,7 +721,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
@property _optionsForQueryParam
*/
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
_optionsForQueryParam(qp: QueryParam): {} {
protected _optionsForQueryParam(qp: QueryParam): {} {
const queryParams = get(this, 'queryParams');
return (
get(queryParams, qp.urlKey) ||
Expand Down Expand Up @@ -1381,7 +1381,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
@param {String} name the name of the controller
@private
*/
generateController(name: string) {
private generateController(name: string) {
let owner = getOwner(this);
assert('Route is unexpectedly missing an owner', owner);

Expand Down Expand Up @@ -1467,7 +1467,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)
@method this[RENDER]
@private
*/
[RENDER]() {
private [RENDER]() {
this[RENDER_STATE] = buildRenderState(this);
once(this._router, '_setOutlets');
}
Expand All @@ -1481,7 +1481,7 @@ class Route<Model = unknown> extends EmberObject.extend(ActionHandler, Evented)

@method teardownViews
*/
teardownViews() {
private teardownViews() {
if (this[RENDER_STATE]) {
this[RENDER_STATE] = undefined;
once(this._router, '_setOutlets');
Expand Down