Checkstyle with checkstyle 9.3#60
Merged
dmikurube merged 1 commit intogradle-version-catalogfrom Feb 17, 2025
Merged
Conversation
hiroyuki-sato
approved these changes
Feb 17, 2025
Member
hiroyuki-sato
left a comment
hiroyuki-sato
left a comment
There was a problem hiding this comment.
LGTM👍 I left two minor comments.
| * @param client | ||
| * @param bucket | ||
| * @param key | ||
| * @return |
Member
There was a problem hiding this comment.
nit: Removing this part is intentional? Is this a checkstyle violation?
Member
Author
There was a problem hiding this comment.
Yeah, it was a checkstyle violation. Checkstyle needed to fill some description for @... notations (not empty), but removing those @... notations were good.
| * @param task | ||
| * @param op | ||
| * @param <T> | ||
| * @return |
Member
There was a problem hiding this comment.
nit: Removing this part is intentional? Is this a checkstyle violation?
Base automatically changed from
LICENSE-and-NOTICE
to
gradle-version-catalog
February 17, 2025 03:39
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.