docs: add structured API reference and inline package comments #52#103
Open
CoolatMax wants to merge 1 commit intoeminwux:mainfrom
Open
docs: add structured API reference and inline package comments #52#103CoolatMax wants to merge 1 commit intoeminwux:mainfrom
CoolatMax wants to merge 1 commit intoeminwux:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: API Documentation & Developer Reference
Overview
This PR addresses Issue #52: API - Add API documentation and usage examples. It establishes a comprehensive documentation suite for the
sbshpublic API, bridging the gap between the Go source code and external developers/integrators.I have implemented a "Documentation-as-Code" approach by combining structured Markdown guides with standard Go inline package comments.
Changes Made
1. Structured API Reference (
docs/api/)Created a new documentation directory containing specialized guides:
index.md: High-level architecture and JSON-RPC over Unix Sockets overview.terminal-api.md&supervisor-api.md: Detailed "Contract" references for the core controllers, documenting methods likeAttach,Resize, andDetach.schemas.md: A full breakdown of theTerminalProfileYAML manifest, mapping Go structs to declarative configuration fields.examples.md: Practical Go code snippets demonstrating client initialization and session management.2. Inline Package Documentation
Added standard Go documentation comments to exported interfaces and structs to support
go docand IDE intellisense:pkg/api/iface.go: DocumentedTerminalControllerandSupervisorController.pkg/api/profile.go: Documented YAML manifest structs (ShellSpec,TerminalProfileDoc).pkg/supervisor/iface.go: Documented the public Supervisor Client interface.3. README Integration
Updated the root
README.mdwith a Developer Resources section, providing direct entry points to the new API documentation.Verification Results
go doc ./pkg/apiandgo doc ./pkg/supervisorcorrectly outputs the new inline comments.schemas.mdwithprofile.goto ensure JSON/YAML tags match the documentation.Closes
Closes #52