Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
static constarrays rather than runtime inputs.Description
Initializerto the IR and parse ONNX initializers inimport_onnx, excluding them from the runtime inputs and storing them on theGraphasinitializers.ConstTensorand add aconstantsfield toLoweredModel, with_lowered_constantsincompilerto lowerInitializers intoConstTensors.CEmitter._emit_constantsandCEmitter._format_floatto render initializer data asstatic const float <name>[...] = { ... };and include the constants section in emitted C before operator functions._ResolvedFeeds.fetchand switchingCompiler.run/internal run paths to use resolved feeds so initializer arrays are returned automatically.tests/test_endtoend_features.py, added a golden filetests/golden/add_initializer_model.c, updatedtests/test_golden.py, and adjustedtests/test_endtoend_ops.pyto remove the duplicated initializer end-to-end test.Testing
pytest -n auto -qand all tests passed (20 passed).Compilertotests/golden/add_initializer_model.cduring the rollout.Codex Task