tests: add official ONNX file list check#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
onnx-orgtest data tree.Description
tests/test_official_onnx_files.pywhich definesOFFICIAL_ONNX_FILEScontaining a sorted list of relative.onnxpaths from the ONNX backend test data._collect_onnx_files(data_root: Path)to gather.onnxfiles recursively and compare that set against the baked-in manifest.test_official_onnx_files()which asserts there are no missing or extra files and reports any mismatches.Testing
pytest tests/test_official_onnx_files.pywhich collected and executed the new test and reported1 passed(success).pytest -k test_official_onnx_filesfailed during global collection due to missing/incorrect ONNX test dependencies (onnx.onnx_cpp2py_export/parameterized), not a failure of the new test itself.Codex Task