tests: use cli verify in end-to-end checks#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verifypath so tests exercise the same compile/build/verify flow used by users.Description
onnx2c verifycommand intests/test_endtoend_features.pyandtests/test_endtoend_ops.py.onnxruntime-based assertions from the tests and delegated numerical verification to the CLIverifycommand, while still asserting emitted initializer array presence/shape in the features test._run_cli_verifyhelper and removed duplicated compiler invocation and temporary binary build steps from the operator tests.Testing
pytest -q tests/test_endtoend_features.py tests/test_endtoend_ops.py.6 passed(all modified end-to-end tests succeeded).verifyinvocation is exercised by the tests and verified to complete successfully.Codex Task